On 12/6/2023 3:09 AM, Krzysztof Kozlowski wrote:
On 05/12/2023 19:47, Markus Mayer wrote:Introduce compatible strings brcm,dpfe-cpu-v1 through brcm,dpfe-cpu-v3 to the Broadcom DPFE driver.No, why?Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx> --- drivers/memory/brcmstb_dpfe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index a7ab3d377206..66876b409e59 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -924,6 +924,12 @@ static const struct of_device_id brcmstb_dpfe_of_match[] = { { .compatible = "brcm,bcm7271-dpfe-cpu", .data = &dpfe_api_old_v2 }, { .compatible = "brcm,bcm7278-dpfe-cpu", .data = &dpfe_api_old_v2 }, { .compatible = "brcm,bcm7211-dpfe-cpu", .data = &dpfe_api_new_v2 }, + + /* Match specific DCPU versions */ + { .compatible = "brcm,dpfe-cpu-v1", .data = &dpfe_api_old_v2 }, + { .compatible = "brcm,dpfe-cpu-v2", .data = &dpfe_api_new_v2 }, + { .compatible = "brcm,dpfe-cpu-v3", .data = &dpfe_api_v3 },Pointless change.
Is it possible to ask you as a maintainer to stop having those knee jerk reactions and try to understand things a bit better, or simply request a better explanation from the submitter?
-- Florian
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
