Hi Gabriel, On Mi, 2023-12-06 at 15:00 +0100, gabriel.fernandez@xxxxxxxxxxx wrote: > From: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx> > > This driver is intended for the STM32MP25 clock family and utilizes > the stm32-core API, similar to the stm32mp13 clock driver. > > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx> > --- [...] > diff --git a/drivers/clk/stm32/stm32mp25_rcc.h b/drivers/clk/stm32/stm32mp25_rcc.h > new file mode 100644 > index 000000000000..b1aca78a0b22 > --- /dev/null > +++ b/drivers/clk/stm32/stm32mp25_rcc.h > @@ -0,0 +1,4977 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Copyright (C) STMicroelectronics 2023 - All Rights Reserved > + * Author: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx> for STMicroelectronics. > + */ > + > +#ifndef STM32MP25_RCC_H > +#define STM32MP25_RCC_H > + > +#define RCC_SECCFGR0 0x0 [...] What is the purpose of all the unused #defines? I initially wanted to point out that the _SHIFT #defines are redundant because the same information is already contained in the corresponding _MASK #defines, but it seems like neither of the register field definitions are used anywhere. It appears only some of the *CFGR register offset #defines are actually used. regards Philipp
