On Wed, Dec 06, 2023 at 07:34:03AM -0600, Rob Herring wrote: > On Wed, Dec 06, 2023 at 01:44:38AM +0000, Daniel Golle wrote: > > Add driver for USXGMII PCS found in the MediaTek MT7988 SoC and supporting > > USXGMII, 10GBase-R and 5GBase-R interface modes. In order to support > > Cisco SGMII, 1000Base-X and 2500Base-X via the also present LynxI PCS > > create a wrapped PCS taking care of the components shared between the > > new USXGMII PCS and the legacy LynxI PCS. > > > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx> > > --- > > .../bindings/net/pcs/mediatek,usxgmii.yaml | 46 +- > > Why are you changing the binding you just added? Oh, that change slipped into the wrong commit by accident, sorry about that, I will fix it in the next iteration. > > In any case, bindings are separate patches. > > > MAINTAINERS | 2 + > > drivers/net/pcs/Kconfig | 11 + > > drivers/net/pcs/Makefile | 1 + > > drivers/net/pcs/pcs-mtk-usxgmii.c | 413 ++++++++++++++++++ > > include/linux/pcs/pcs-mtk-usxgmii.h | 26 ++ > > 6 files changed, 456 insertions(+), 43 deletions(-) > > create mode 100644 drivers/net/pcs/pcs-mtk-usxgmii.c > > create mode 100644 include/linux/pcs/pcs-mtk-usxgmii.h