On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: > >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { > >> + { .compatible = "starfive,jh7110-inno-hdmi",}, > > > > So it's inno hdmi, just like Rockchip then? > > > > This should be a common driver. > > Rockchip has a inno hdmi IP. and Starfive has a inno hdmi IP. > but the harewawre difference of them is big , it is not easy to use the common driver > maybe i need the inno hdmi version here to make a distinction I just had a look at the rockchip header file: all the registers but the STARFIVE_* ones are identical. There's no need to have two identical drivers then, please use the rockchip driver instead. Maxime
Attachment:
signature.asc
Description: PGP signature