> >> On Tue, Dec 05, 2023 at 07:55:50PM +0800, Inochi Amaoto wrote: >>> Add definition for the clock controller of the CV1800 series SoC. >>> >>> Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx> >>> Link: https://github.com/milkv-duo/duo-files/blob/main/hardware/CV1800B/CV1800B-CV1801B-Preliminary-Datasheet-full-en.pdf >>> --- >>> .../bindings/clock/sophgo,cv1800-clk.yaml | 53 ++++++ >>> include/dt-bindings/clock/sophgo,cv1800.h | 174 ++++++++++++++++++ >>> 2 files changed, 227 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml >>> create mode 100644 include/dt-bindings/clock/sophgo,cv1800.h >>> >>> diff --git a/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml b/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml >>> new file mode 100644 >>> index 000000000000..388be5bfa163 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/clock/sophgo,cv1800-clk.yaml >>> @@ -0,0 +1,53 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/clock/sophgo,cv1800-clk.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Sophgo CV1800 Series Clock Controller >>> + >>> +maintainers: >>> + - Inochi Amaoto <inochiama@xxxxxxxxxxx> >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - sophgo,cv1800-clk >>> + - sophgo,cv1810-clk >> >> I'm not reading 1000s of lines of driver code to figure it out, what >> differs in the programming model for these two devices? > >In fact, they have no different in the programming model. The only >different between them is that cv1810 have one extra clock. > >> You should >> mention in your commit message why the cv1810 has an incompatible >> programming model if you are adding multiple devices in one commit >> message. >> > >OK, I will > >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + clocks: >>> + items: >>> + - description: Oscillator (25 MHz) >> >> This could just be "maxItems: 1". >> > >OK, thanks. > >>> + >>> + clock-names: >>> + items: >>> + - const: osc >> >> You have one clock, why do you need a name? > >I am not pretty familiar with this. I just wrote this binding by >referencing others. Maybe use "maxItems: 1" is just fine? > I have referenced this name in the clk_parent_data as the global clock parent. Removing this will cause driver broken. >> >> Otherwise, this looks okay, thanks. >> >> >
