Hi @serge, there is some more DT_CHECKER warning & need to fix that before uploading the new patch . Will fix the warning & then will update the version , Thanks Suraj On 12/5/2023 3:35 PM, Serge Semin wrote: > Hi Suraj > > On Mon, Dec 04, 2023 at 02:16:12PM -0600, Andrew Halaney wrote: >> On Mon, Dec 04, 2023 at 06:56:14PM +0530, Suraj Jaiswal wrote: >>> Add support to listen Ethernet HW safery IRQ. The safety IRQ will be >> >> s/safery/safety/ >> >>> triggered for ECC, DPP, FSM error. >>> >>> Changes since v3: >> >> This is listed as v3 in the subject, but it should now be v4 since the >> last version was v3. > > There are several style-type problems I would like to share. But as > Andrew correctly noted the series version was incorrectly left > unchanged. Please resubmit the series with the version incremented. > I'll send my comments to that new thread so the discussion history and > the lore archive would look cleaner. Thanks. > > -Serge(y) > >> >>> - Fix DT_CHECKER warning >>> - use name safety for the IRQ. >>> >>> >>> Suraj Jaiswal (3): >>> dt-bindings: net: qcom,ethqos: add binding doc for safety IRQ for >>> sa8775p >>> arm64: dts: qcom: sa8775p: enable safety IRQ >>> net: stmmac: Add driver support for DWMAC5 safety IRQ Support >>> >>> .../devicetree/bindings/net/qcom,ethqos.yaml | 9 ++++++--- >>> .../devicetree/bindings/net/snps,dwmac.yaml | 5 +++-- >>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 10 ++++++---- >>> drivers/net/ethernet/stmicro/stmmac/common.h | 1 + >>> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ >>> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 18 ++++++++++++++++++ >>> .../ethernet/stmicro/stmmac/stmmac_platform.c | 9 +++++++++ >>> 7 files changed, 45 insertions(+), 9 deletions(-) >>> >>> -- >>> 2.25.1 >>> >> >>
