On 12/5/23 17:28, Andy Shevchenko wrote: >> + ref_label = ad7173_ref_sel_str[AD7173_SETUP_REF_SEL_INT_REF]; >> + >> + fwnode_property_read_string(child, "adi,reference-select", >> + &ref_label); >> + ref_sel = match_string(ad7173_ref_sel_str, >> + ARRAY_SIZE(ad7173_ref_sel_str), ref_label); >> + if (ref_sel < 0) { > Can we use fwnode_property_match_property_string()? fwnode_property_match_string() searches a given string in a device-tree string array and returns the index. I do not think that this function fits here as the DT attribute is a single string.