On Tue, Dec 05, 2023 at 01:35:22PM +0300, Serge Semin wrote: > There are currently two methods (xpcs_find_compat() and > xpcs_get_interfaces()) defined in the driver which loop over the available > interfaces. All of them rely on the xpcs_compat.num_interfaces field value > to get the number of interfaces. That field is initialized with the > ARRAY_SIZE(xpcs_*_interfaces) macro function call. Thus the interface > arrays are supposed to be filled with actual interface IDs and there is no > need in the dummy terminating ID placed at the end of the arrays. Let's > drop the redundant PHY_INTERFACE_MODE_MAX entry from the > xpcs_2500basex_interfaces list and the redundant > PHY_INTERFACE_MODE_MAX-based conditional statement from the > xpcs_get_interfaces() method then. It would help the readability of the commit message if you would split it into multiple paragraphs. > > Signed-off-by: Serge Semin <fancer.lancer@xxxxxxxxx> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
