On 05/12/2023 10:17, Kamel BOUHARA wrote: > Le 2023-12-05 09:15, Krzysztof Kozlowski a écrit : >> On 04/12/2023 15:05, Kamel Bouhara wrote: >>> Add the TouchNetix axiom I2C touchscreen device tree bindings >>> documentation. >>> >>> Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> >> >>> +$id: >>> http://devicetree.org/schemas/input/touchscreen/touchnetix,ax54a.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: TouchNetix Axiom series touchscreen controller >>> + >>> +maintainers: >>> + - Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx> >>> + >> >> Why you do not have ref to touchscreen? Is it not a touchscreen? > > The common properties are not used or applicable here, should I still > ref touchscreen ? Why they are not applicable? Do you get the panel coordinates and sizes from device registers or are they fixed somehow in the controller? ... > >>> + description: I/O power supply regulator on VDDI pin >>> + >>> +required: >>> + - compatible >>> + - reg >> >> Supplies are usually required. Devices rarely can operate without >> power. > > Indeed, can I still have them optional in the driver ? Yes, I comment here only about the bindings. Bindings are not related to your driver, but to hardware. Best regards, Krzysztof
