Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Sent: Tuesday, December 5, 2023 8:47 AM > Subject: Re: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog: > Document DA9063 watchdog > > Hi Biju, > > On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Document DA9063 watchdog device as it is similar to DA9062 watchdog. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > --- > > v3->v3.1: > > * Added Ack from Conor Dooley. > > * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063. > > * Retained Rb tag since the changes are trivial. > > Thanks for the update! > > > --- > > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y > > +++ aml > > > @@ -18,6 +18,7 @@ properties: > > - items: > > - enum: > > - dlg,da9062-watchdog > > + - dlg,da9063-watchdog > > - items: > > - const: dlg,da9061-watchdog > > - const: dlg,da9062-watchdog > > This matches the existing usage in DT, so > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > However, I believe we do have a runtime issue here, as the driver > currently matches against dlg,da9062-watchdog only, so the watchdog must > be non-functional on DA9063? Of_compatible is defined in [1], but the corresponding driver[2] is missing the compatible [1] drivers/mfd/da9063-core.c: .of_compatible = "dlg,da9063-watchdog", [2] drivers/watchdog/da9063_wdt.c Not sure of_compaible in MFD will instantiate driver [2] or not? Cheers, Biju