On 29/11/2023 14:47, Konrad Dybcio wrote: > On 29.11.2023 14:22, Krzysztof Kozlowski wrote: >> Add the Low Power Audio SubSystem (LPASS) / ADSP audio codec macros on >> Qualcomm SM8650. The nodes are very similar to SM8550. >> >> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Bindings were documented here: >> https://lore.kernel.org/linux-devicetree/20231129113014.38837-1-krzysztof.kozlowski@xxxxxxxxxx/ >> --- >> arch/arm64/boot/dts/qcom/sm8650.dtsi | 83 ++++++++++++++++++++++++++++ >> 1 file changed, 83 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> index e926329cf3f9..cf663a18c9f0 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi >> @@ -2611,6 +2611,89 @@ IPCC_MPROC_SIGNAL_GLINK_QMP >> }; >> }; >> >> + lpass_wsa2macro: codec@6aa0000 { >> + compatible = "qcom,sm8650-lpass-wsa-macro", "qcom,sm8550-lpass-wsa-macro"; >> + reg = <0 0x06aa0000 0 0x1000>; >> + clocks = <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6prmcc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&q6prmcc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>, >> + <&lpass_vamacro>; >> + clock-names = "mclk", "macro", "dcodec", "fsgen"; > one per line? ack > >> + assigned-clocks = <&q6prmcc LPASS_CLK_ID_WSA2_CORE_TX_MCLK LPASS_CLK_ATTRIBUTE_COUPLE_NO>; >> + assigned-clock-rates = <19200000>; Hm, I tested now on SM8550 and it seems not needed. I will drop it. Best regards, Krzysztof
