Hi Conor,
On 12/3/23 13:20, Conor Dooley wrote:
On Sat, Dec 02, 2023 at 01:48:33PM +0100, Karel Balej wrote:
From: Markuss Broks <markuss.broks@xxxxxxxxx>
Imagis IST3038B is a variant (firmware?) of Imagis IST3038 IC,
add the compatible for it to the IST3038C bindings.
This one is better, but would be well served by mentioning what
specifically is different (register addresses or firmware commands?)
I don't think anyone knows this other than Imagis itself. I would guess
it's different hardware, since register addresses are indeed different,
but on the other hand, there is a possibility that firmware on the MCU
could be responding to those commands. I suppose "... IST3038B is a
hardware variant of ... IST3038" would be more correct.
The reason why I think it could be firmware-defined is because we have a
lot of variants (30xxA, 30xxB, 30xxC, plain 30xx), and the numbers
usually mean feature level/completeness, e.g. some don't support the
touch pressure or touchkeys, and we don't know what A/B/C/none means.
Cheers,
Conor.
Signed-off-by: Markuss Broks <markuss.broks@xxxxxxxxx>
Signed-off-by: Karel Balej <balejk@xxxxxxxxx>
---
.../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
index 0d6b033fd5fb..b5372c4eae56 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
@@ -18,6 +18,7 @@ properties:
compatible:
enum:
+ - imagis,ist3038b
- imagis,ist3038c
reg:
--
2.43.0
- Markuss
