On 12/1/23 17:07, Conor Dooley wrote:
On Fri, Dec 01, 2023 at 09:35:27AM +0100, Michal Simek wrote:
On 11/30/23 15:58, Conor Dooley wrote:
On Thu, Nov 30, 2023 at 09:46:54AM +0100, Michal Simek wrote:
arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts is defining 30 channels
that's why increase it.
But AMS binding defines 51 channels
Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
that's why increase number to 51.
Please write commit messages for bindings in terms of how they relate to
some hardware. In this case I think it would be sufficient to say that
the Analog Monitoring system has 51 channels, the opening sentence about
the dts as justification provides no actionable information.
Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
v2 sent.
I wasn't requesting a v2 FWIW. "$file uses 30 channels" rather than
rephrasing it in terms of the hardware actually having 51 channels just
annoyed me, that's all.
I know and I agreed that commit message can be improved that's why sent v2.
Thanks,
Michal
