On Sat, Dec 2, 2023 at 8:58 AM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Tue, Nov 28, 2023 at 12:45 AM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote: > > > > @@ -44,6 +46,7 @@ trackpad2: trackpad@2c { > > reg = <0x2c>; > > hid-descr-addr = <0x0020>; > > wakeup-source; > > + status = "fail-needs-probe"; > > While doing this, you could also remove the hack where the trackpad > IRQ pinctrl is listed under i2c4. Sure. I do think we can do away with it though. According to at least one schematic, the interrupt line has pull-ups on both sides of the voltage shifter. BTW, The touchscreen doesn't have pinctrl entries. This has pull-ups on both sides of the voltage shifter as well. ChenYu