On Fri, 1 Dec 2023 10:48:20 +0000 Lee Jones <lee@xxxxxxxxxx> wrote: > > + if (err) { > > + pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err); > > It would save an awful lot of lines and space if we could place these > warnings/errors inside twl_i2c_read_u8(). Well, it is already in twl_i2c_read() ... yes, we can save quite some lines. Regards, Andreas