> +/** > + * enum - Types of PSE controller. > + * > + * @PSE_UNKNOWN: Type of PSE controller is unknown > + * @PSE_PODL: PSE controller which support PoDL > + * @PSE_C33: PSE controller which support Clause 33 (PoE) > + */ > +enum { > + PSE_UNKNOWN = BIT(0), > + PSE_PODL = BIT(1), > + PSE_C33 = BIT(2), > +}; Maybe this should be in the netlink API? I think you can imply it by looking at what properties are in the netlink reply, but having it explicitly is probably better. ethtool(1) can default to PSE_PODL if the property is missing for an older kernel. Andrew