Hi Thomas,
On 14/01/2015 20:22, Thomas Petazzoni wrote:
> Dear Gregory CLEMENT,
>
> On Wed, 14 Jan 2015 18:39:11 +0100, Gregory CLEMENT wrote:
>
>> +Required properties:
>> +- compatible : Should be "marvell,armada-380-rtc"
>> +- reg: physical base address of the controller and length of memory
>> + mapped region, associated to the reg-name "rtc". The other entry is
>> + related to the interrupt control from the SoC, associated to the
>> + reg-name "soc-interrupt".
>
> soc-interrupt or...
I changed all the name from soc-interrupt to soc-int except here.
I will fix it.
>
>> +- reg-names: names of the mapped memory regions listed in regs
>> + property in the same order: "rtc" and "soc-int".
>
> soc-int ?
>
>> +rtc@a3800 {
>> + compatible = "marvell,armada-380-rtc";
>> + reg = <0xa3800 0x20>, <0x184a0 0x0c>;
>
> Any reason to use <0x184A0 0xC> instead of <0x184A8 0x4> ? According to
> the datasheet, there is only this 184A8 register for RTC stuff.
Yes but according to the code I saw there were other registers related to the RTC
from 0x184A0. Even if we don't use them now I prefer having an accurate mapping from
the beginning for avoiding using negative offset as we needed to do in the past.
Thanks,
Gregory
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
