Hi Biju,
On Fri, Dec 1, 2023 at 12:09 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Convert the da9062 PMIC device tree binding documentation to json-schema.
>
> Update the example to match reality.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/mfd/da9062.txt
> +++ /dev/null
This file is still referred to from other files:
$ git grep Documentation/devicetree/bindings/mfd/da9062.txt
Documentation/devicetree/bindings/input/da9062-onkey.txt:DA9062
and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt
Documentation/devicetree/bindings/thermal/da9062-thermal.txt:DA9062
and DA9061 chips see Documentation/devicetree/bindings/mfd/da9062.txt
> -- onkey : See ../input/da9062-onkey.txt
Documentation/devicetree/bindings/input/da9062-onkey.txt still exists,
and covers more variants than your new dlg,da9062.yaml.
> -
> -- watchdog: See ../watchdog/da9062-wdt.txt
This was replaced by
Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
a while ago, and covers more variants than your new dlg,da9062.yaml.
> -
> -- thermal : See ../thermal/da9062-thermal.txt
Documentation/devicetree/bindings/thermal/da9062-thermal.txt still exists,
and covers more variants than your new dlg,da9062.yaml.
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/dlg,da9062.yaml
> @@ -0,0 +1,220 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/dlg,da9062.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dialog DA9062 Power Management Integrated Circuit (PMIC)
> +
> +maintainers:
> + - Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> +
> +description: |
> + Product information for the DA9062 and DA9061 devices can be found here:
> + - https://www.dialog-semiconductor.com/products/da9062
> + - https://www.dialog-semiconductor.com/products/da9061
> +
> + The DA9062 PMIC consists of:
> +
> + Device Supply Names Description
> + ------ ------------ -----------
> + da9062-regulator : : LDOs & BUCKs
> + da9062-rtc : : Real-Time Clock
> + da9062-onkey : : On Key
> + da9062-watchdog : : Watchdog Timer
> + da9062-thermal : : Thermal
> + da9062-gpio : : GPIOs
> +
> + The DA9061 PMIC consists of:
> +
> + Device Supply Names Description
> + ------ ------------ -----------
> + da9062-regulator : : LDOs & BUCKs
> + da9062-onkey : : On Key
> + da9062-watchdog : : Watchdog Timer
> + da9062-thermal : : Thermal
da9061 (x4)
> +
> +properties:
> + watchdog:
Please sort subnodes alphabetically.
> + type: object
> + $ref: /schemas/watchdog/watchdog.yaml#
> + unevaluatedProperties: false
> + properties:
> + compatible:
> + const: dlg,da9062-watchdog
What about dlg,da9061-watchdog? Probably this should refer to
Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
instead?
This applies to the other subnodes, too.
Perhaps this binding should be merged with dlg,da9063.yaml?
Or should it be split in dlg,da9061.yaml and dlg,da9062.yaml?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
