On 29.11.2023 21:59, Bryan O'Donoghue wrote: > On 29/11/2023 18:59, Konrad Dybcio wrote: >> Instead of magically poking at the bit0 of branch clocks' CBCR, use >> the newly introduced helper. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> --- > >> - /* >> - * Keep clocks always enabled: >> - * cam_cc_gdsc_clk >> - * cam_cc_sleep_clk >> - */ >> - regmap_update_bits(regmap, 0x1419c, BIT(0), BIT(0)); >> - regmap_update_bits(regmap, 0x142cc, BIT(0), BIT(0)); >> + qcom_branch_set_clk_en(regmap, 0x1419c); /* CAM_CC_GDSC_CLK */ >> + qcom_branch_set_clk_en(regmap, 0x142cc); /* CAM_CC_SLEEP_CLK */ > > This all looks functionally correct to me, wondering what your motivation for changing the comment is though. Perhaps I could have included this in the commit message, but: - it makes sure ARRAY_SIZE(clocks_in_comment) == ARRAY_SIZE(clocks) - gets rid of different capitalization and wording between files that triggers my OCD - also makes it easier to see which register corresponds to which clock, which is especially helpful if you wanna validate the guy before you Konrad
