On Wed, Nov 29, 2023 at 5:08 PM Nuno Sá <noname.nuno@xxxxxxxxx> wrote: > Cool, I actually thought that having the direction + get/set stuff would be weird > given the fact that we can only PULL_LOW or HIGH_Z the pins. There are several drivers in the kernel that implement .set_config(), it's existing and should be enabled if it has uses. As Andy points out: when the driver reaches a certain complexity, such as a huge table of muxable pins (that need to be configured to a certain muxing from device tree), and numerous complicated pin config options (also needing to be set up from device tree), it may be worth to implement a separate pin control driver that act as "backend" for the GPIO driver. I think a separate pin control driver would be overkill in this case, it's a PWM driver with some smallish GPIO portions AFAICT, but you get to decide. Yours, Linus Walleij
