On Tue, 2023-09-19 at 09:47 +0100, Conor Dooley wrote: > Guo, > > On Tue, Sep 19, 2023 at 02:08:32PM +0900, Kwanghoon Son wrote: > > > > > + - const: thead,th1520-reset > > > > > + - const: syscon > > > > > > > > iDumb question perhaps, but why is this a syscon? > > > > > > This is good point. > > > In fact, I took it from the vendor kernel, and I tried to keep it as same as I could. > > > Vendor also followed drivers/reset/reset-imx7.c > > > As Rob said, if don't need it, I'll change it. > > > I have investigated vendor kernels, but it is still not sure reset information. > > I thought this is about sys_reg, but without datasheet, can't tell. > > Therefore, should be stopped patch for a while until knows better comes out. > > Is there documentation in English you can provide to these people that > are trying to add support for your product? It can be downloaded from https://dl.sipeed.com/shareURL/LICHEE/licheepi4a/09_Doc now. Click on "TH1520 User Manual.zip" and enter a captcha. The doc about resetting is in chapter 5 of "TH1520 System User Manual.pdf". -- Xi Ruoyao <xry111@xxxxxxxxxxx> School of Aerospace Science and Technology, Xidian University
