On 29/11/2023 07:00, Sia Jee Heng wrote: > Add new compatible string for UART in the StarFive JH8100 SoC. > > Signed-off-by: Sia Jee Heng <jeeheng.sia@xxxxxxxxxxxxxxxx> > Reviewed-by: Ley Foon Tan <leyfoon.tan@xxxxxxxxxxxxxxxx> The patch is quite different than v1. Are you sure the review is applicable? If it was given for v2, where is it? > --- > Documentation/devicetree/bindings/serial/cdns,uart.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.yaml b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > index e35ad1109efc..0d05305778f2 100644 > --- a/Documentation/devicetree/bindings/serial/cdns,uart.yaml > +++ b/Documentation/devicetree/bindings/serial/cdns,uart.yaml > @@ -20,6 +20,10 @@ properties: > items: > - const: xlnx,zynqmp-uart > - const: cdns,uart-r1p12 > + - description: UART controller for StarFive JH8100 SoC This is duplicating compatible, drop. > + items: > + - const: starfive,jh8100-uart > + - const: cdns,uart-r1p8 Don't add things to the end of the list, but keep order. I would suggest to put it at the beginning, so before Xilinx. Best regards, Krzysztof
