On Tue, Nov 28, 2023 at 9:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 28/11/2023 14:22, jingbao qiu wrote:
> >>> + if (ret)
> >>> + goto err;
> >>> +
> >>> + rtc->clk = devm_clk_get(&pdev->dev, NULL);
> >>> + if (IS_ERR(rtc->clk)) {
> >>> + dev_err(&pdev->dev, "no clock");
> >>
> >> This code is not ready for upstream. There are multiple things wrong here.
> >>
> >> First, syntax is return dev_err_probe.
> >>
> >> Second, you do not have clocks and you do not allow them! Just open your
> >> binding.
> >
> > I'm not fully understanding here, can you elaborate more?
>
> That the syntax is dev_err_probe() or that you do not have clocks?
>
>
> > as there is clocks info like this in the dt-bindings:
> > clocks = <&osc>;
>
> Really?
>
> Point me to the line in your patch:
>
> +properties:
> + compatible:
> + enum:
> + - sophgo,cv1800b-rtc
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
>
> Where are the clocks?
I will fix properties.
>
>
> Best regards,
> Krzysztof
>
Best regards,
Jingbao Qiu
