Hi Heiko:
On 11/28/23 16:30, Heiko Stübner wrote:
Am Dienstag, 28. November 2023, 09:03:46 CET schrieb Andy Yan:
Hi Heiko:
On 11/27/23 23:02, Heiko Stübner wrote:
Am Mittwoch, 22. November 2023, 13:54:25 CET schrieb Andy Yan:
From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
The enable bit and transform offset of cluster windows should be
cleared when it work at linear mode, or we may have a iommu fault
issue.
Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
I guess same here?
Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver")
I'm not sure if we need a Fixes tag here, in fact this issue never happens on
rk3566/8 , because the cluster windows of rk356x only support afbc format,
they don't have a chance to switch between afbc and linear mode.
Of course, the lack support of linear mode of rk356x cluster windows is a thoughtless
of IC design, if it really support both afbc and linear format, we indeed need this fix.
The situation is the same as patch 03/12.
So I hope follow your advice, if it need a Fixes tag here.
ah ok, thanks for the explanation. Then I guess we don't need a fixes tag
when the rk3568 is not affected by this.
Same for the other patch. If you're re-sending you could add this information
to the commit message though. (existing support for rk3568 only supports
afbc cluster windows and is therefore not affected)
Ok, will done.
Thanks
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-rockchip
