On 28/11/2023 09:37, Jacky Huang wrote:
>>> + gpion: gpio@40040340 {
>>> + reg = <0x340 0x40>;
>>> + interrupts = <GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&clk GPN_GATE>;
>>> + gpio-controller;
>>> + #gpio-cells = <2>;
>>> + interrupt-controller;
>>> + #interrupt-cells = <2>;
>>> + };
>>> +
>>> + pcfg_default: pin-default {
>>> + slew-rate = <0>;
>>> + input-schmitt-disable;
>>> + bias-disable;
>>> + power-source = <1>;
>>> + drive-strength = <17100>;
>>> + };
>> It does not look like you tested the DTS against bindings. Please run
>> `make dtbs_check W=1` (see
>> Documentation/devicetree/bindings/writing-schema.rst or
>> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
>> for instructions).
>>
>> Best regards,
>> Krzysztof
>>
>
> I forgot to remove 'ma35d1-pinfunc.h' from my local copy.
> After remove the '#include <dt-bindings/pinctrl/ma35d1-pinfunc.h>', it
> can pass
> the `make dtbs_check W=1` check.
> I will fix it in the next version.
Really? Then your bindings look wrong. Why do you mix MMIO nodes and
non-MMIO in one device node?
Best regards,
Krzysztof
