On 28/11/2023 09:59, Neil Armstrong wrote: > On 24/11/2023 09:33, Krzysztof Kozlowski wrote: >> On 23/11/2023 15:49, Neil Armstrong wrote: >> >>> + Qualcomm WCD9390/WCD9395 Codec is a standalone Hi-Fi audio codec IC. >>> + It has RX and TX Soundwire slave devices. >>> + The WCD9390/WCD9395 IC has a functionally separate USB-C Mux subsystem >>> + accessible over an I2C interface. >>> + The Audio Headphone and Microphone data path between the Codec and the USB-C Mux >>> + subsystems are external to the IC, thus requiring DT port-endpoint graph description >>> + to handle USB-C altmode & orientation switching for Audio Accessory Mode. >>> + >>> +allOf: >>> + - $ref: dai-common.yaml# >>> + - $ref: qcom,wcd93xx-common.yaml# >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - qcom,wcd9390-codec >>> + - qcom,wcd9395-codec >> >> 9395 should be compatible with 9390, so please express it with a list >> using fallback. I know that earlier wcd93xx do not follow that concept, >> but maybe we will fix them some point as well. > > I don't get why this would be needed, yes their are compatible but still > two separate ICs with different internal capabilities. > > It the first time I get such request for new documentation Maybe it is first time for you, but I ask about this all the time. What is important is whether the programming model or how the OS uses the device is the same. Here the device exposes its version in registers, so you can easily rely on the compatibility. That's also the case multiple times talked on the mailing lists. Best regards, Krzysztof
