Re: [PATCH 0/3] ARM: dts: bcm2711-rpi-cm4-io: Enable xHCI host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Cyril,

Am 27.11.23 um 12:55 schrieb Cyril Brulebois:
Hi Stefan,

Stefan Wahren <wahrenst@xxxxxxx> (2023-11-27):
thanks for testing. Are you absolutely sure that you are using
bcm2711-rpi-cm4-io.dtb from the mainline tree?
I'm pretty sure, yes.

Starting from the unpatched kernel:

     root@rpi4-20231108:~# md5sum /boot/firmware/bcm2711-rpi-cm4-io.dtb /usr/lib/linux-image-6.6.0+/broadcom/bcm2711-rpi-cm4-io.dtb
     5cbe07e9f85ddfefd21ffe98bf92f5ea  /boot/firmware/bcm2711-rpi-cm4-io.dtb
     5cbe07e9f85ddfefd21ffe98bf92f5ea  /usr/lib/linux-image-6.6.0+/broadcom/bcm2711-rpi-cm4-io.dtb

The second file is shipped by the linux-image package built via `make
bindeb-pkg`, and sync'd into /boot/firmware as the first one.

After deploying the patched kernel, I'm seeing both files getting
updated:

     root@rpi4-20231108:~# md5sum /boot/firmware/bcm2711-rpi-cm4-io.dtb /usr/lib/linux-image-6.6.0+/broadcom/bcm2711-rpi-cm4-io.dtb
     c6ea63f43dcdf8ecd66dda6c494f52e2  /boot/firmware/bcm2711-rpi-cm4-io.dtb
     c6ea63f43dcdf8ecd66dda6c494f52e2  /usr/lib/linux-image-6.6.0+/broadcom/bcm2711-rpi-cm4-io.dtb

Comparing a copy of the first set of files against the refreshed DTB,
I'm seeing the attached (dt)diff.

I would expect the following hardware name: Raspberry Pi Compute
Module 4 IO Board
I suppose this is an arm(32) vs. arm64 difference?

  - setup_arch() in arch/arm/kernel/setup.c does this:

         machine_desc = mdesc;
         machine_name = mdesc->name;
         dump_stack_set_arch_desc("%s", mdesc->name);

  - setup_machine_fdt() in arch/arm64/kernel/setup.c does that:

         name = of_flat_dt_get_machine_name();
         if (!name)
                 return;

         pr_info("Machine model: %s\n", name);
         dump_stack_set_arch_desc("%s (DT)", name);

So I'd guess you're testing on arm(32) and seeing the name embedded in
the DTB while I'm testing on arm64 and seeing the name as filled by the
bootloader?
thanks for your fast feedback. Shame on me, i didn't test arm64 yet.

Could you please provide the following information:

- settings of config.txt
- VC firmware version
- did you use arm64/defconfig or something special?

Be aware the arm files has been moved into a broadcom subdirectory.
Thanks for mentioning that, but I've been working on arm64 exclusively,
and those files have always been shipped in that broadcom subdirectory
anyway.

With 64-bit capable hardware, I didn't think of mentioning I was testing
64-bit kernel and user space (Debian 12, arm64), sorry about that.
No problem

Thanks


Cheers,





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux