On 27 November 2023 00:35:45 EET, Daniel Golle <daniel@xxxxxxxxxxxxxx> wrote: >On Sat, Aug 12, 2023 at 01:45:29AM +0300, Arınç ÜNAL wrote: >> On 10.08.2023 01:01, Vladimir Oltean wrote: >> > [...] >> > Since commit fe7324b93222 ("net: dsa: OF-ware slave_mii_bus"), DSA as a >> > framework also supports auto-creating an internal MDIO bus based on the >> > presence of the "mdio" node name, so I guess it makes sense for the >> > "mdio" to appear in the generic dsa.yaml if there's nothing else that's >> > special about it. >> >> I agree with this. I've done this which works. It's even found a port >> node with the ethernet property missing, as it should've. > >Are you planning to complete/submit your work below? >I'm asking because being able to reference the PHYs on the internal >MDIO bus is mandatory on MT7988 which requires calibration data from >NVMEM for each PHY, so supporting MT7988 depends on the associated >driver change[1]. > >[1]: https://patchwork.kernel.org/project/netdevbpf/patch/6eb1b7b8dbc3a4b14becad15f0707d4f624ee18b.1691246461.git.daniel@xxxxxxxxxxxxxx/ This patch triggered conversation on a deeper level regarding the devicetree bindings aspect of it. I will continue discussing that with the maintainers here and achieve a mutual agreement. To get things going on the driver side, I think it's fine to submit that as a single patch. I'll do that in a week, if nobody else does it first. Arınç