On Sat, 2023-11-25 at 07:39 +0800, kernel test robot wrote: > Hi Nuno, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on groeck-staging/hwmon-next] > [also build test WARNING on linus/master v6.7-rc2 next-20231124] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Nuno-Sa-via-B4-Relay/hwmon-ltc4282-add-support-for-the-LTC4282-chip/20231124-231842 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next > patch link: > https://lore.kernel.org/r/20231124-ltc4282-support-v2-2-952bf926f83c%40analog.com > patch subject: [PATCH v2 2/2] hwmon: ltc4282: add support for the LTC4282 chip > config: x86_64-randconfig-161-20231125 > (https://download.01.org/0day-ci/archive/20231125/202311250548.lUn3bm1A-lkp@intel.c > om/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): > (https://download.01.org/0day-ci/archive/20231125/202311250548.lUn3bm1A-lkp@intel.c > om/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > Closes: > > https://lore.kernel.org/oe-kbuild-all/202311250548.lUn3bm1A-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > > > drivers/hwmon/ltc4282.c:347:6: warning: no previous prototype for > > > 'ltc4282_round_rate' [-Wmissing-prototypes] > 347 | long ltc4282_round_rate(struct clk_hw *hw, unsigned long rate, > | ^~~~~~~~~~~~~~~~~~ > > > drivers/hwmon/ltc4282.c:356:15: warning: no previous prototype for > > > 'ltc4282_recalc_rate' [-Wmissing-prototypes] > 356 | unsigned long ltc4282_recalc_rate(struct clk_hw *hw, unsigned long > parent) > | ^~~~~~~~~~~~~~~~~~~ > > > vim +/ltc4282_round_rate +347 drivers/hwmon/ltc4282.c > > 346 > > 347 long ltc4282_round_rate(struct clk_hw *hw, unsigned long rate, > 348 unsigned long *parent_rate) > 349 { > 350 int idx = find_closest(rate, ltc4282_out_rates, > 351 ARRAY_SIZE(ltc4282_out_rates)); > 352 > 353 return ltc4282_out_rates[idx]; > 354 } > 355 > > 356 unsigned long ltc4282_recalc_rate(struct clk_hw *hw, unsigned long parent) > 357 { > 358 struct ltc4282_state *st = container_of(hw, struct ltc4282_state, > 359 clk_hw); > 360 u32 clkdiv; > 361 int ret; > 362 > 363 ret = regmap_read(st->map, LTC4282_CLK_DIV, &clkdiv); > 364 if (ret) > 365 return 0; > 366 > 367 clkdiv = FIELD_GET(LTC4282_CLKOUT_MASK, clkdiv); > 368 if (!clkdiv) > 369 return 0; > 370 if (clkdiv == LTC4282_CLKOUT_INT) > 371 return LTC4282_CLKOUT_SYSTEM; > 372 > 373 return LTC4282_CLKOUT_CNV; > 374 } > 375 > Arghh, I do need to see if I can add some test branch of my own to the test robot :/. Anyways, will wait for some more reviewing before sending v3 to address this. - Nuno Sá
