On Thu, 23 Nov 2023 13:41:28 -0300 Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote: > Move AD7091R register, channel and event definitions to the header file > so other AD7091R device drivers may use those declaration in follow up > patches. Hi, This is moving stuff into the base.c file as well, but the patch description doesn't talk about that or the exports added. It should describe those parts. Looks good otherwise - one trivial comment below. Jonathan > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > diff --git a/drivers/iio/adc/ad7091r-base.h b/drivers/iio/adc/ad7091r-base.h > index 509748aef9b1..6ff539cd1d39 100644 > --- a/drivers/iio/adc/ad7091r-base.h > +++ b/drivers/iio/adc/ad7091r-base.h > @@ -8,6 +8,27 @@ ... > > +bool ad7091r_volatile_reg(struct device *dev, unsigned int reg); > + Trivial but I'd not have a blank line here. > +bool ad7091r_writeable_reg(struct device *dev, unsigned int reg); > + > #endif /* __DRIVERS_IIO_ADC_AD7091R_BASE_H__ */
