On Thu, 23 Nov 2023 13:40:16 -0300
Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:
Hi Marcelo,
Thanks for the patch. Content looks fine but it wants breaking up into
2 fixes and one reformat.
> Write 1 to bit 4 in the configuration register to set ALERT/BUSY/GPO pin
> to be used as ALERT.
That's s one fix.
> Set device driver data so it can be retrieved when handling alert
> events, avoiding null pointer dereference.
That's one fix - so this should be at least 2 patches.
>
> Fixes: <ca69300173b6> (iio: adc: Add support for AD7091R5 ADC)
That's not the syntax for a fixes tag.
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> ---
> drivers/iio/adc/ad7091r-base.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7091r-base.c b/drivers/iio/adc/ad7091r-base.c
> index 8e252cde735b..3ecac3164446 100644
> --- a/drivers/iio/adc/ad7091r-base.c
> +++ b/drivers/iio/adc/ad7091r-base.c
> @@ -28,6 +28,7 @@
> #define AD7091R_REG_RESULT_CONV_RESULT(x) ((x) & 0xfff)
>
> /* AD7091R_REG_CONF */
> +#define AD7091R_REG_CONF_ALERT_EN BIT(4)
> #define AD7091R_REG_CONF_AUTO BIT(8)
> #define AD7091R_REG_CONF_CMD BIT(10)
>
> @@ -232,9 +233,16 @@ int ad7091r_probe(struct device *dev, const char *name,
> iio_dev->channels = chip_info->channels;
>
> if (irq) {
> + ret = regmap_update_bits(st->map, AD7091R_REG_CONF,
> + AD7091R_REG_CONF_ALERT_EN, BIT(4));
> + if (ret)
> + return ret;
> +
> + dev_set_drvdata(st->dev, iio_dev);
> ret = devm_request_threaded_irq(dev, irq, NULL,
> - ad7091r_event_handler,
> - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, name, st);
> + ad7091r_event_handler,
> + IRQF_TRIGGER_FALLING |
> + IRQF_ONESHOT, name, st);
This is alignment cleanup. Should not be in a fix.
> if (ret)
> return ret;
> }
