Andrew, Florian, Thoughts? On Mon, 06 Nov 2023, Shiji Yang wrote: > These two types of LEDs are widely used in routers and NICs. > > The 'signal' LED is used to display the wireless signal strength. > Usually, there are 3~4 LEDs in one group to indicate the signal > strength, similar to the signal icon on a mobile phone. > > The 'internet' LED can indicate whether the device can access a > specific server. It's different from 'wan'. 'wan' usually indicates > whether the WAN port is connected to the modem (internet services > may still be unavailable). But the 'internet' shows if the device > can successfully ping servers such as 8.8.8.8 to detect the internet > connection status. When the router is running in AP only mode, we > can even connect LAN port to the AC/modem to connect to the internet. > In this case, the 'internet' LED should be on. On some routers, both > 'internet' and 'wan' are available and can be controlled separately. > > Signed-off-by: Shiji Yang <yangshiji66@xxxxxxxxxxx> > --- > > Changes in v2: > * Remove the LED name sorting patch as it changes the ABI. > * Add "devicetree@xxxxxxxxxxxxxxx" to '--to' list. > Thanks to Rob Herring and Krzysztof Kozlowski for letting me know I > can send patch to multiple mailing list at once. > > Changes in v3: > * Add more information about the new added LEDs. > * Remove the missing LED fix as Jisheng Zhang has already sent a > similar one. I should search the mailing list first... > > Changes in v4: > * Rename 'rssi' LED to more generic name 'signal'. I forgot to update > the source file in v3. > > v1: > https://lore.kernel.org/all/TYAP286MB0315FE921FF113BF76F7B700BCA0A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > v2: > https://lore.kernel.org/all/TYAP286MB03159A83A77E6FD59F271D9BBCA0A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > v3: > https://lore.kernel.org/all/TYAP286MB0315AE8F62E6AB48E3F9A0DDBCA5A@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > > include/dt-bindings/leds/common.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > index 9a0d33d02..f831c5dba 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -88,6 +88,7 @@ > #define LED_FUNCTION_FLASH "flash" > #define LED_FUNCTION_HEARTBEAT "heartbeat" > #define LED_FUNCTION_INDICATOR "indicator" > +#define LED_FUNCTION_INTERNET "internet" > #define LED_FUNCTION_LAN "lan" > #define LED_FUNCTION_MAIL "mail" > #define LED_FUNCTION_MTD "mtd" > @@ -95,6 +96,7 @@ > #define LED_FUNCTION_PROGRAMMING "programming" > #define LED_FUNCTION_RX "rx" > #define LED_FUNCTION_SD "sd" > +#define LED_FUNCTION_SIGNAL "signal" > #define LED_FUNCTION_STANDBY "standby" > #define LED_FUNCTION_TORCH "torch" > #define LED_FUNCTION_TX "tx" > -- > 2.39.2 > -- Lee Jones [李琼斯]
