On 23. 11. 23. 05:04, Krzysztof Kozlowski wrote: > Older ARM8 SoCs like Exynos5433, Exynos7 and Exynos7885 have the pin > controller with wake-up interrupts muxed, thus the wake-up interrupt > controller device node has interrupts property, while its pin banks > might not (because they are muxed by the wake-up controller). > > Newer SoCs like Exynos850 and ExynosAutov9 do not used muxed wake-up > interrupts: > 1. Wake-up interrupt controller device node has no interrupts, > 2. Its pin banks have interrupts (since there is no muxing). > > Their programming interface is however still compatible with Exynos7, > thus change the bindings to express this: retain compatibility with > Exynos7 and add new compatibility fallback of Exynos850 in newer > designs. > > No driver changes are needed. This is necessary only to properly > describe DTS. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Acked-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx> I will also apply it to ExynosAutov920 DT patch. Thanks Jaewon Kim > > --- > > Cc: Peter Griffin <peter.griffin@xxxxxxxxxx> > Cc: semen.protsenko@xxxxxxxxxx > Cc: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx> > --- > .../samsung,pinctrl-wakeup-interrupt.yaml | 25 +++++++++++-------- > 1 file changed, 15 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > index 1b75abebb953..2bafa867aea2 100644 > --- a/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml > @@ -36,13 +36,17 @@ properties: > - samsung,s5pv210-wakeup-eint > - samsung,exynos4210-wakeup-eint > - samsung,exynos7-wakeup-eint > - - samsung,exynos850-wakeup-eint > - - samsung,exynosautov9-wakeup-eint > - - samsung,exynosautov920-wakeup-eint > - items: > - enum: > - samsung,exynos5433-wakeup-eint > - samsung,exynos7885-wakeup-eint > + - samsung,exynos850-wakeup-eint > + - const: samsung,exynos7-wakeup-eint > + - items: > + - enum: > + - samsung,exynosautov9-wakeup-eint > + - samsung,exynosautov920-wakeup-eint > + - const: samsung,exynos850-wakeup-eint > - const: samsung,exynos7-wakeup-eint > > interrupts: > @@ -86,11 +90,14 @@ allOf: > - if: > properties: > compatible: > - contains: > - enum: > - - samsung,s5pv210-wakeup-eint > - - samsung,exynos4210-wakeup-eint > - - samsung,exynos7-wakeup-eint > + # Match without "contains", to skip newer variants which are still > + # compatible with samsung,exynos7-wakeup-eint > + enum: > + - samsung,s5pv210-wakeup-eint > + - samsung,exynos4210-wakeup-eint > + - samsung,exynos5433-wakeup-eint > + - samsung,exynos7-wakeup-eint > + - samsung,exynos7885-wakeup-eint > then: > properties: > interrupts: > @@ -105,8 +112,6 @@ allOf: > contains: > enum: > - samsung,exynos850-wakeup-eint > - - samsung,exynosautov9-wakeup-eint > - - samsung,exynosautov920-wakeup-eint > then: > properties: > interrupts: false
