Hello, On Wed Nov 22, 2023 at 1:00 PM CET, Krzysztof Kozlowski wrote: > On 22/11/2023 11:46, Théo Lebrun wrote: > > - properties: > > compatible: > > oneOf: > > - const: ti,j7200-usb > > - items: > > - const: ti,j721e-usb > > - const: ti,am64-usb > > > > J721E & AM64 are compatible, express that & update devicetrees. > > > > Option one is simpler & doesn't change devicetrees so I'd lean in that > > direction. What's your opinion? > > This one should be for am64. > > For your j7200, it depends whether the fallback to j721e makes sense, > IOW, if the Linux can use j721e compatible solely to use j7200 device. All compatibles might be equivalent if the reset-on-resume behavior is observed on all three platforms. I don't have access to J721E or AM64 to test that. @Roger Quadros: do you have any news if USB suspend/resume works on J721E and/or AM64? My testing on the J7200 EVM is (1) boot, (2) put the "USB2.0_MUX_SEL" GPIO high to have USB devices connected without plugging anything, then (3) trigger a s2idle. I get a memory bus exception on resume without my patches. Regards, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
