Re: [PATCH v2 3/5] dt-bindings: stm32: add clocks and reset binding for stm32mp25 platform

[Gabriel FERNANDEZ <gabriel.fernandez@xxxxxxxxxxx>]

Hi Rob, thanks for your review


On 11/19/23 16:23, Rob Herring wrote:
> On Thu, Nov 16, 2023 at 04:49:50PM +0100, gabriel.fernandez@xxxxxxxxxxx wrote:
> > From: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> >
> > Adds clock and reset binding entries for STM32MP25 SoC family
> >
> > Signed-off-by: Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> > ---
> >   .../bindings/clock/st,stm32mp25-rcc.yaml      |  72 +++
> >   include/dt-bindings/clock/st,stm32mp25-rcc.h  | 492 ++++++++++++++++++
> >   include/dt-bindings/reset/st,stm32mp25-rcc.h  | 165 ++++++
> >   3 files changed, 729 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml
> >   create mode 100644 include/dt-bindings/clock/st,stm32mp25-rcc.h
> >   create mode 100644 include/dt-bindings/reset/st,stm32mp25-rcc.h
> >
> > diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml
> > new file mode 100644
> > index 000000000000..1bdcfacd62d5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/st,stm32mp25-rcc.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/st,stm32mp25-rcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STM32MP25 Reset Clock Controller
> > +
> > +maintainers:
> > +  - Gabriel Fernandez <gabriel.fernandez@xxxxxxxxxxx>
> > +
> > +description: |
> > +  The RCC hardware block is both a reset and a clock controller.
> > +  RCC makes also power management (resume/supend).
> > +
> > +  See also::
> > +    include/dt-bindings/clock/st,stm32mp25-rcc.h
> > +    include/dt-bindings/reset/st,stm32mp25-rcc.h
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - st,stm32mp25-rcc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  '#reset-cells':
> > +    const: 1
> > +
> > +  clocks:
> > +    description: Specifies oscillators.
> > +    maxItems: 5
> > +
> > +  clock-names:
> > +    items:
> > +      - const: hse
> > +      - const: hsi
> > +      - const: msi
> > +      - const: lse
> > +      - const: lsi
> No idea what these TLAs are... Define them in clocks:
>
> clocks:
>    items:
>      - description: what hse is
>      - ...
ok  i will send a v3


Best Regards

Gabriel