On 21/11/2023 15:47, Paller, Kim Seer wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Tuesday, November 21, 2023 9:05 PM >> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx> >> Cc: Jonathan Cameron <jic23@xxxxxxxxxx>; Lars-Peter Clausen >> <lars@xxxxxxxxxx>; Hennerich, Michael <Michael.Hennerich@xxxxxxxxxx>; >> Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski >> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; >> linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- >> kernel@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: frequency: add admfm2000 >> >> [External] >> >> On 21/11/2023 11:00, Kim Seer Paller wrote: >>> Dual microwave down converter module with input RF and LO frequency >>> ranges from 0.5 to 32 GHz and an output IF frequency range from 0.1 to >>> 8 GHz. It consists of a LNA, mixer, IF filter, DSA, and IF amplifier >>> for each down conversion path. >>> >>> Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx> >>> --- >>> V1 -> V2: Removed '|' after description. Specified the pins connected to >>> the GPIOs. Added additionalProperties: false. Changed node name to >> gpio. >> >> Why? Is this a GPIO? Your bindings title say this is a converter, not a >> GPIO. > > I might have used an incorrect generic name, considering that it utilizes GPIOs > for controlling both mode and attenuation. What would be the appropriate > name to use in this context? git grep @ -- Documentation/devictree/bindings/iio/frequency I would go with converter. Best regards, Krzysztof
