On Mon, 20 Nov 2023 10:18:30 +0100
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> On 18/11/2023 12:14, Pavel Löbl wrote:
> > Banana Pi P2 Zero is H2+-based board by Sinovoip internally similar
> > to Banana Pi M2 Zero.
> >
>
>
> > diff --git
> > a/arch/arm/boot/dts/allwinner/sun8i-h2-plus-bananapi-p2-zero-v1.1.dts
> > b/arch/arm/boot/dts/allwinner/sun8i-h2-plus-bananapi-p2-zero-v1.1.dts
> > new file mode 100644 index 000000000000..f963051d8ff5 --- /dev/null
> > +++
> > b/arch/arm/boot/dts/allwinner/sun8i-h2-plus-bananapi-p2-zero-v1.1.dts
> > @@ -0,0 +1,290 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>
> Unusual license. We usually do not want GPL-v5.0. Does anything
> requires such licensing? If not, use 2.0 OR MIT
License was copied from sun8i-h2-plus-bananapi-m2-zero as it served as
base for this DT. It seems GPL-2.0+ identifier is deprecated. So I
should replace it with GPL-2.0-or-later, probably.
>
> > +/*
> > + * Copyright (C) 2023 Pavel Löbl <pavel@xxxxxxxx>
> > + *
> > + * Based on sun8i-h2-plus-bananapi-m2-zero.dts, which is:
> > + * Copyright (C) 2017 Icenowy Zheng <icenowy@xxxxxxx>
> > + */
> > +
> > +/dts-v1/;
> > +#include "sun8i-h3.dtsi"
> > +
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/leds/common.h>
> > +
> > +/ {
> > + model = "Banana Pi BPI-P2-Zero v1.1";
> > + compatible = "sinovoip,bananapi-p2-zero-v1.1",
> > "allwinner,sun8i-h2-plus";
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
Fixed for next version.
> > +
> > + aliases {
> > + serial0 = &uart0;
> > + serial1 = &uart1;
> > + };
> > +
> > + chosen {
> > + stdout-path = "serial0:115200n8";
> > + };
> > +
> > + connector {
> > + compatible = "hdmi-connector";
> > + type = "c";
> > +
> > + port {
> > + hdmi_con_in: endpoint {
> > + remote-endpoint = <&hdmi_out_con>;
> > + };
> > + };
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > +
> > + led {
> > + function = LED_FUNCTION_POWER;
> > + color = <LED_COLOR_ID_RED>;
> > + gpios = <&r_pio 0 10 GPIO_ACTIVE_LOW>; /*
> > PL10 */
> > + default-state = "on";
> > + };
> > + };
> > +
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > +
> > + power {
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
Replaced with switch-2 to match schematic.
Pavel
