On Mon, Nov 20, 2023 at 05:43:22PM +0100, Johan Hovold wrote:
> The DP/DM wakeup interrupts are edge triggered and which edge to trigger
> on depends on use-case and whether a Low speed or Full/High speed device
> is connected.
>
> Note that only triggering on rising edges can be used to detect resume
> events but not disconnect events.
>
> Fixes: de1001525c1a ("arm64: dts: qcom: sa8775p: add USB nodes")
> Cc: Shazad Hussain <quic_shazhuss@xxxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Reviewed-by: Andrew Halaney <ahalaney@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index b6a93b11cbbd..4b42a329460c 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -1610,8 +1610,8 @@ usb_0: usb@a6f8800 {
> assigned-clock-rates = <19200000>, <200000000>;
>
> interrupts-extended = <&intc GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>,
> - <&pdc 14 IRQ_TYPE_EDGE_RISING>,
> - <&pdc 15 IRQ_TYPE_EDGE_RISING>,
> + <&pdc 14 IRQ_TYPE_EDGE_BOTH>,
> + <&pdc 15 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 12 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "pwr_event",
> "dp_hs_phy_irq",
> @@ -1697,8 +1697,8 @@ usb_1: usb@a8f8800 {
> assigned-clock-rates = <19200000>, <200000000>;
>
> interrupts-extended = <&intc GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>,
> - <&pdc 8 IRQ_TYPE_EDGE_RISING>,
> - <&pdc 7 IRQ_TYPE_EDGE_RISING>,
> + <&pdc 8 IRQ_TYPE_EDGE_BOTH>,
> + <&pdc 7 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 13 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-names = "pwr_event",
> "dp_hs_phy_irq",
> @@ -1760,8 +1760,8 @@ usb_2: usb@a4f8800 {
> assigned-clock-rates = <19200000>, <200000000>;
>
> interrupts-extended = <&intc GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>,
> - <&pdc 10 IRQ_TYPE_EDGE_RISING>,
> - <&pdc 9 IRQ_TYPE_EDGE_RISING>;
> + <&pdc 10 IRQ_TYPE_EDGE_BOTH>,
> + <&pdc 9 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "pwr_event",
> "dp_hs_phy_irq",
> "dm_hs_phy_irq";
> --
> 2.41.0
>
>
