Re: [PATCH 1/2] dt-bindings: hwmon: Add LTC4282 bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/13/23 01:32, Nuno Sá wrote:

+
+  clocks:
+    maxItems: 1
+
+  adi,clkout-mode:
+    description: |
+      Controls in which mode the CLKOUT PIN should work:
+        0 - Configures the CLKOUT pin to output the internal system clock
+        1 - Configures the CLKOUT pin to output the internal conversion
time
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [0, 1]

I really am not a fan of these types of properties. Part of me says that
if you're outputting clocks from this device, then you should be a clock
controller. How do consumers of this @clkout@ pin get the rate of the
clock?

I explained it to Guenter as he also argued about this. I'll wait for more
feedback but it's likely this will just turn into a clock provider, yes.


That wasn't an argument, it was a request. If the chip acts as clock provider,
it needs to register as one if that functionality is used/provided.

Guenter





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux