Re: [PATCH 2/2] hwmon: ltc4282: add support for the LTC4282 chip

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 11/20/23 04:10, Dan Carpenter wrote:
> Hi Nuno,
>
> kernel test robot noticed the following build warnings:
>
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Nuno-Sa/dt-bindings-hwmon-Add-LTC4282-bindings/20231110-232017
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> patch link:    https://lore.kernel.org/r/20231110151905.1659873-3-nuno.sa%40analog.com
> patch subject: [PATCH 2/2] hwmon: ltc4282: add support for the LTC4282 chip
> config: i386-randconfig-141-20231112 (https://download.01.org/0day-ci/archive/20231113/202311130219.YBiF8Xu3-lkp@xxxxxxxxx/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20231113/202311130219.YBiF8Xu3-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> | Closes: https://lore.kernel.org/r/202311130219.YBiF8Xu3-lkp@xxxxxxxxx/
>
> smatch warnings:
> drivers/hwmon/ltc4282.c:859 ltc4282_is_visible() warn: signedness bug returning '(-524)'
> drivers/hwmon/ltc4282.c:1143 ltc4282_gpio_setup() warn: passing zero to 'dev_err_probe'
>
> vim +859 drivers/hwmon/ltc4282.c
>
> 31ea069ddf481b Nuno Sa 2023-11-10  844  static umode_t ltc4282_is_visible(const void *data,
> 31ea069ddf481b Nuno Sa 2023-11-10  845  				  enum hwmon_sensor_types type,
> 31ea069ddf481b Nuno Sa 2023-11-10  846  				  u32 attr, int channel)
> 31ea069ddf481b Nuno Sa 2023-11-10  847  {
> 31ea069ddf481b Nuno Sa 2023-11-10  848  	switch (type) {
> 31ea069ddf481b Nuno Sa 2023-11-10  849  	case hwmon_in:
> 31ea069ddf481b Nuno Sa 2023-11-10  850  		return ltc4282_in_is_visible(data, attr);
> 31ea069ddf481b Nuno Sa 2023-11-10  851  	case hwmon_curr:
> 31ea069ddf481b Nuno Sa 2023-11-10  852  		return ltc4282_curr_is_visible(attr);
> 31ea069ddf481b Nuno Sa 2023-11-10  853  	case hwmon_power:
> 31ea069ddf481b Nuno Sa 2023-11-10  854  		return ltc4282_power_is_visible(attr);
> 31ea069ddf481b Nuno Sa 2023-11-10  855  	case hwmon_energy:
> 31ea069ddf481b Nuno Sa 2023-11-10  856  		/* hwmon_energy_enable */
> 31ea069ddf481b Nuno Sa 2023-11-10  857  		return 0644;
> 31ea069ddf481b Nuno Sa 2023-11-10  858  	default:
> 31ea069ddf481b Nuno Sa 2023-11-10 @859  		return -ENOTSUPP;
>
> This function returns umode_t (which must be unsigned and smaller than
> int for this warning to trigger).

Yes, this is an is_visible() function which should return 0 if the attribute
isn't visible.

Guenter