Am Sonntag, 19. November 2023, 13:13:36 CET schrieb Alex Bee: > Commit 51a9b2c03dd3 ("phy: rockchip-inno-usb2: Handle ID IRQ") added ID > detection interrupt registers. However the current implementation assumes > that falling and rising edge interrupt are always enabled in registers > spanning over subsequent bits. > That is not the case for RK3128's version of the phy and this > implementation can't be used as-is, since there are bits with different > purpose in between. > > This splits up the register definitions for id_det_en, id_det_en and > id_det_clr registers in rising and falling edge variants. > It's required as preparation to support RK3128's Innosilicon usb2 phy as > well in this driver and matches pretty much to what the vendor does, so I'm > not expecting issues for other SoCs with that change. > > Signed-off-by: Alex Bee <knaerzche@xxxxxxxxx> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>