Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
From: Jie Luo <quic_luoj@xxxxxxxxxxx>
Date: Mon, 20 Nov 2023 16:56:32 +0800
Cc: <andrew@xxxxxxx>, <davem@xxxxxxxxxxxxx>, <edumazet@xxxxxxxxxx>, <pabeni@xxxxxxxxxx>, <robh+dt@xxxxxxxxxx>, <krzysztof.kozlowski+dt@xxxxxxxxxx>, <conor+dt@xxxxxxxxxx>, <hkallweit1@xxxxxxxxx>, <linux@xxxxxxxxxxxxxxx>, <corbet@xxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <linux-doc@xxxxxxxxxxxxxxx>
In-reply-to: <20231118162214.7093d46c@kernel.org>
User-agent: Mozilla Thunderbird



On 11/19/2023 8:22 AM, Jakub Kicinski wrote:

On Sat, 18 Nov 2023 14:27:52 +0800 Luo Jie wrote:

+static inline bool phydev_id_is_qca808x(struct phy_device *phydev)


Please drop the "inline" keyword. The compiler will decide what's best.


OK, will remove the "inline" in the next patch.

References:
- [PATCH v5 0/6] add qca8084 ethernet phy driver
  - From: Luo Jie
- [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
  - From: Luo Jie
- Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
  - From: Jakub Kicinski

Prev by Date: Re: [PATCH 14/14] arm: multi_v7_defconfig: Enable CONFIG_RAVB
Next by Date: Re: [PATCH 14/14] arm: multi_v7_defconfig: Enable CONFIG_RAVB
Previous by thread: Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x
Next by thread: [PATCH v5 5/6] net: phy: at803x: Add qca8084_config_init function
Index(es):
- Date
- Thread

[Index of Archives] [Device Tree Compilter] [Device Tree Spec] [Linux Driver Backports] [Video for Linux] [Linux USB Devel] [Linux PCI Devel] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [XFree86] [Yosemite Backpacking]

Powered by Linux