On Sat, 18 Nov 2023 01:06:09 +0100 Marek Vasut <marex@xxxxxxx> wrote: > The ISL76682 is very basic ALS which only supports ALS or IR mode > in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any > other fancy functionality. Document it as trivial device. > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Signed-off-by: Marek Vasut <marex@xxxxxxx> I'm always a bit in 2 minds about trivial-devices as it doesn't include a basic power supply. In this case vdd which I'd prefer to see documented even on such a simple device as this. Not everyone is going to leave it powered up all the time! Still I'm not that fussed. Maybe it's worth allowing vdd-supply in trivial-devices.yaml? Jonathan > --- > Cc: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx> > Cc: Andre Werner <andre.werner@xxxxxxxxxxxxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > Cc: Conor Dooley <conor+dt@xxxxxxxxxx> > Cc: Fabio Estevam <festevam@xxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Cc: Jonathan Cameron <jic23@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> > Cc: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> > Cc: Mark Brown <broonie@xxxxxxxxxx> > Cc: Matti Vaittinen <mazziesaccount@xxxxxxxxx> > Cc: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx> > Cc: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@xxxxxxxx> > Cc: Vincent Tremblay <vincent@xxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-iio@xxxxxxxxxxxxxxx > --- > V2: Add AB from Conor > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index c3190f2a168a2..27164e9219276 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -179,6 +179,8 @@ properties: > - isil,isl29030 > # Intersil ISL68137 Digital Output Configurable PWM Controller > - isil,isl68137 > + # Intersil ISL76682 Ambient Light Sensor > + - isil,isl76682 > # Linear Technology LTC2488 > - lineartechnology,ltc2488 > # 5 Bit Programmable, Pulse-Width Modulator
