On Sun, Nov 19, 2023 at 12:26:37PM +0200, Elad Nachman wrote: > From: Elad Nachman <enachman@xxxxxxxxxxx> > > Add dt bindings for: > CN9130 COM Express CPU module Did you forget this one? There's only the CN9191 system here. > CN9131 COM Express CPU module > AC5X RD COM Express Type 7 carrier board. > AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. > > Signed-off-by: Elad Nachman <enachman@xxxxxxxxxxx> > --- > .../bindings/arm/marvell/armada-7k-8k.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..6b19f23bcf63 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,16 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus > + Armada CN9131 COM Express CPU module > + items: > + - enum: > + - marvell,ac5x-car-with-cn9131 Why not just marvell,cn9131-ac5x-carrier or similar? The "with" isn't particularly helpful. Cheers, Conor. > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9131-cpu-module > + - const: marvell,cn9131 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > -- > 2.25.1 >
Attachment:
signature.asc
Description: PGP signature