On 16.11.2023 21:44, Rob Herring wrote: > On Thu, Nov 16, 2023 at 12:12 PM Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> wrote: >> >> Document preferred coding style for Devicetree sources (DTS and DTSI), >> to bring consistency among all (sub)architectures and ease in reviews. > > Thanks for doing this. > >> >> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> >> Cc: Arnd Bergmann <arnd@xxxxxxxx> >> Cc: Bjorn Andersson <andersson@xxxxxxxxxx> >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> Cc: Heiko Stuebner <heiko@xxxxxxxxx> >> Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx> >> Cc: Michal Simek <michal.simek@xxxxxxx> >> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> >> Cc: Nishanth Menon <nm@xxxxxx> >> Cc: Olof Johansson <olof@xxxxxxxxx> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- [...] >> +Example:: >> + >> + thermal-sensor@c271000 { >> + compatible = "qcom,sm8550-tsens", "qcom,tsens-v2"; >> + reg = <0x0 0x0c271000 0x0 0x1000>, >> + <0x0 0x0c222000 0x0 0x1000>; > > You should cover the <> style too, meaning <> around each logical entry. FWIW this matters because e.g. https://github.com/devicetree-org/devicetree-specification/issues/66 Konrad