Hi Mehdi, One more thing: On 11/16/23 12:04, Mehdi Djait wrote: > [...] > diff --git a/drivers/media/platform/rockchip/cif/capture.h b/drivers/media/platform/rockchip/cif/capture.h > new file mode 100644 > index 000000000000..533e62f518da > --- /dev/null > +++ b/drivers/media/platform/rockchip/cif/capture.h > @@ -0,0 +1,21 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Rockchip CIF Driver > + * > + * Copyright (C) 2023 Mehdi Djait <mehdi.djait@xxxxxxxxxxx> > + */ > + > +#ifndef _CIF_CAPTURE_H > +#define _CIF_CAPTURE_H > + > +struct cif_device; > + > +void cif_unregister_stream_vdev(struct cif_device *dev); > +int cif_register_stream_vdev(struct cif_device *dev); > +void cif_stream_init(struct cif_device *dev); > +void cif_set_default_format(struct cif_device *dev); > + > +irqreturn_t cif_irq_pingpong(int irq, void *ctx); > +void cif_soft_reset(struct cif_device *cif_dev); This cif_soft_reset occurs only here?! I think it should be removed. > + > +#endif > [...] With that (and maybe the renaming "Rockchip CIF Camera Interface" -> "Rockchip Camera Interface (CIF)" throughout the driver, if you find that suitable) addressed: Reviewed-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx> Thanks and best regards, Michael
