On Wed, Nov 15, 2023 at 01:55:07PM +0100, Wojciech Drewek wrote: > Hi Romain, > I see that you splitted the patch, thanks for that. > However it's still too big IMHO, edma ipqess_edma could be introduced in seperate file e.g. I agree that it's way too much code in one go (also too much code in general). It doesn't help that much of it is blindly copied from DSA or duplicated from the qca8k driver from the without much thought. It looks like the EDMA portion could be separated from the switch portion.
