On 11/15/23 16:38, Isaev Ruslan wrote:
Add node to support this bus inside of IPQ6018.
For example, this bus is used to work with the
voltage regulator (mp5496) on the Yuncore AX840 wireless AP.
Signed-off-by: Isaev Ruslan <legale.legale@xxxxxxxxx>
---
v1 -> v2: fix clocks typo; fix reg size warning.
Hi, it's also good practice to share a link to the previous
revision for easier comparison. The b4 tool [1] takes care
of most of the comments you've got.
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index e59b9df96..00a61de9d 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -506,6 +506,21 @@ blsp1_i2c3: i2c@78b7000 {
dma-names = "tx", "rx";
status = "disabled";
};
+
+ blsp1_i2c6: i2c@78ba000 {
+ compatible = "qcom,i2c-qup-v2.2.1";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x0 0x078ba000 0x0 0x600>;
+ interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
The irq number seems a bit sus.. they're usually more or less contiguous
and I2C3 uses SPI97.. Are you sure it's the correct one?
Konrad
[1] https://b4.docs.kernel.org/en/latest/
