On 14/11/2023 23:37, Zev Weiss wrote: > >>> + }; >>> + >>> + memory@80000000 { >>> + reg = <0x80000000 0x20000000>; >>> + }; >>> + >>> + leds { >>> + compatible = "gpio-leds"; >>> + >>> + heartbeat { >> >> It does not look like you tested the DTS against bindings. Please run >> `make dtbs_check W=1` (see >> Documentation/devicetree/bindings/writing-schema.rst or >> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ >> for instructions). The node names are clearly wrong and you got output. It's easy to spot if your patch worked in the first place: fatal error: dt-bindings/watchdog/aspeed-wdt.h: No such file or directory Best regards, Krzysztof