> -----Original Message----- > From: Conor Dooley <conor@xxxxxxxxxx> > Sent: Friday, November 10, 2023 1:10 AM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx> > Cc: patrick@xxxxxxxxx; Jean Delvare <jdelvare@xxxxxxxx>; Guenter Roeck > <linux@xxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; > Jonathan Corbet <corbet@xxxxxxx>; linux-i2c@xxxxxxxxxxxxxxx; > linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver > bindings > > On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote: > > Add a device tree bindings for ltc4286 device. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > > > Changelog: > > v4 - Revise some inappropriate writing in yaml file > > v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable > > v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6 > > - Add type for adi,vrange-select-25p6 > > - Revise rsense-micro-ohms to shunt-resistor-micro-ohms > > Your changelog should be below the --- line. We will add --- line on our changelog. > You also omitted the tag I left on the previous version. Could you point out the exact places that we omit? Thanks. > With the changelog fixed: > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Cheers, > Conor. > > > --- > > .../bindings/hwmon/lltc,ltc4286.yaml | 51 > +++++++++++++++++++ > > MAINTAINERS | 10 ++++ > > 2 files changed, 61 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > new file mode 100644 > > index 000000000000..d26f34fb7ea7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > @@ -0,0 +1,51 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: LTC4286 power monitors > > + > > +maintainers: > > + - Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - lltc,ltc4286 > > + - lltc,ltc4287 > > + > > + reg: > > + maxItems: 1 > > + > > + adi,vrange-low-enable: > > + description: > > + This property is a bool parameter to represent the > > + voltage range is 25.6 volts or 102.4 volts for this chip. > > + The default is 102.4 volts. > > + type: boolean > > + > > + shunt-resistor-micro-ohms: > > + description: > > + Resistor value micro-ohms. > > + > > +required: > > + - compatible > > + - reg > > + - shunt-resistor-micro-ohms > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + power-monitor@40 { > > + compatible = "lltc,ltc4286"; > > + reg = <0x40>; > > + adi,vrange-low-enable; > > + shunt-resistor-micro-ohms = <300>; > > + }; > > + }; > > diff --git a/MAINTAINERS b/MAINTAINERS index > > 0b275b8d6bd2..5d439cd64ecb 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -12609,6 +12609,16 @@ S: Maintained > > F: Documentation/hwmon/ltc4261.rst > > F: drivers/hwmon/ltc4261.c > > > > +LTC4286 HARDWARE MONITOR DRIVER > > +M: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx> > > +L: linux-i2c@xxxxxxxxxxxxxxx > > +S: Maintained > > +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml > > +F: Documentation/devicetree/bindings/hwmon/ltc4286.rst > > +F: drivers/hwmon/pmbus/Kconfig > > +F: drivers/hwmon/pmbus/Makefile > > +F: drivers/hwmon/pmbus/ltc4286.c > > + > > LTC4306 I2C MULTIPLEXER DRIVER > > M: Michael Hennerich <michael.hennerich@xxxxxxxxxx> > > L: linux-i2c@xxxxxxxxxxxxxxx > > -- > > 2.25.1 > > > >
